[3.x] Fix strict-mode break #7604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `Get-Member` instead of assuming `$null` property value - fixes build break I caused in 13040ff
2 tasks
riarenas
approved these changes
Jul 9, 2021
Contributor
riarenas
left a comment
riarenas
left a comment
There was a problem hiding this comment.
LGTM. I filled out the servicing template, and we will need approval from @markwilkie or @mmitche for changes to this branch.
Contributor
|
I'll just merge it as this is needed to fix a build break and the change has been working fine in the other branches. Good catch that we hadn't ported this @lukas-lansky! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7564 for 3.1 servicing Fixes build break caused by #7531
Customer Impact
All repos that build using VS will be unable to take further arcade updates.
Regression
Yes
Risk
How risky is this change?
Not at all. The fix is already in main and in the release/5.x branch
Workarounds
None