Skip to content

Conversation

@MattGal
Copy link
Member

@MattGal MattGal commented Jul 1, 2021

Follow up from #7383. This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation (Alpine chosen because it's small, and the original reason the Helix Docker feature exists)

To double check:

Follow up from #7383.  This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation (Alpine chosen because it's small, and the original reason the Helix Docker feature exists)
@MattGal MattGal requested a review from missymessa July 1, 2021 18:39
Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

@MattGal
Copy link
Member Author

MattGal commented Jul 1, 2021

Abandoning this PR since it's not immediately obvious what's going on, put logs and thoughts into https://github.com/dotnet/core-eng/issues/13581

@MattGal
Copy link
Member Author

MattGal commented Aug 25, 2021

I can't click reopen here but this should work now, so rebased off main and opened #7790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants