#13433: product builds secret configuration #7583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubstilec
changed the title
MattGal
reviewed
Jul 2, 2021
Member
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
Seems reasonable, but I'd like to understand the "set to never expire" means in the context of a SAS token
alexperovich
reviewed
Jul 6, 2021
jakubstilec
force-pushed
the
jastilec/13433
branch
from
a36a0af to
7534b08
Compare
alexperovich
approved these changes
Jul 12, 2021
added 2 commits
July 13, 2021 17:23
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/core-eng/issues/13433 - secret manager configuration for product builds, these won't be executed until build pipeline is modified
To double check: