Skip to content

Conversation

@ViktorHofer
Copy link
Member

To double check:

Removing net463 and net46 as these newer shipped a targeting pack and these tfms are already disabled in dotnet/runtime's package validation.

Removing tfms that aren't supported in dotnet/runtime anymore.

@ViktorHofer ViktorHofer requested review from Anipik and ericstj June 8, 2021 11:01
@ViktorHofer ViktorHofer self-assigned this Jun 8, 2021
@ViktorHofer
Copy link
Member Author

@Anipik looks like netcoreapp3.1 isn't chosen because it isn't the min version and netcoreapp2.0 isn't in the list. Is that assumption right? If yes, what would need to change to choose the minimum supported .NETCoreApp version based on our support policy and not based on the netstandard compatibility matrix?

@Anipik
Copy link
Contributor

Anipik commented Jun 8, 2021

Will take a look at the failures here later today.

@ViktorHofer
Copy link
Member Author

thanks 👍

@Anipik
Copy link
Contributor

Anipik commented Jun 10, 2021

#7510

@ViktorHofer we can close this one. the tests and code here has drastically changed.

@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch June 11, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants