enable cg2 by default in sharedfx

[mangod9]

Updating sharedfx.targets to use crossgen2 by default for ReadyToRun, similar change has been done within the sdk but that doesnt seem to take effect while building with sharedFx.targets.

With active work to decomm crossgen1 need to get this propagated to all repos so we could resolve any outstanding issues.

I have validated that WindowsDesktop repo does use crossgen2 if I manually update its sharedFx.targets with this change.

[trylek]

Awesome, thank you!

[AntonLapounov]

I think that setting PublishReadyToRun should be moved to sharedfx.props. That way SDK will set PublishReadyToRunUseCrossgen2 to true.

[jkoritzinsky]

We can't move it there because the PlatformPackageType property is set in the user's project file, and the sharedfx.props file gets imported before properties there are read.

[mangod9]

yeah tested by moving it to props, but PublishReadyToRun is not set if moved.

[AntonLapounov]

That is unfortunate. We should probably remove the '$(PublishReadyToRun)' == 'true' condition from this SDK line: https://github.com/dotnet/sdk/blob/751fb14a10203d201b18ec8557f8422e13afe998/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.CrossGen.targets#L14

[mangod9]

We should probably remove the '$(PublishReadyToRun)' == 'true' condition from this SDK

yeah might make sense to do that change. Let me merge this and we can undo once the SDK change makes it through.