Skip to content

Remove empty XHarness logs #7418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
premun merged 1 commit into from
May 21, 2021
Merged

Remove empty XHarness logs #7418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-runner.apple.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ if [ -z "$targets" ]; then
die "No targets were provided";
fi

if [ -z "$output_directory" ]; then
die "No output directory provided";
fi

if [ -z "$xharness_cli_path" ]; then
die "XHarness path wasn't provided";
fi
Expand Down Expand Up @@ -156,6 +160,9 @@ fi
# The simulator logs comming from the sudo-spawned Simulator.app are not readable by the helix uploader
chmod 0644 "$output_directory"/*.log

# Remove empty files
find "$output_directory" -name "*.log" -maxdepth 1 -size 0 -print -delete
Copy link
Contributor

@ChadNedzlek ChadNedzlek May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if helix should just not upload zero-byte files in general. It seems sort of pointless to do.

Copy link
Member Author

@premun premun May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same but no idea if someone relies on it somehow somewhere


if [ "$command" == 'test' ]; then
test_results=$(ls "$output_directory"/xunit-*.xml)

Expand Down