Skip to content

Reduce parallelism of publishing upload clients #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattGal merged 1 commit into from
May 19, 2021
Merged

Reduce parallelism of publishing upload clients #7414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,17 @@ public abstract class PublishArtifactsInManifestBase : Microsoft.Build.Utilities
[Required]
public string NugetPath { get; set; }

private const int StreamingPublishingMaxClients = 20;
private const int NonStreamingPublishingMaxClients = 16;
private const int StreamingPublishingMaxClients = 16;
private const int NonStreamingPublishingMaxClients = 12;

/// <summary>
/// Maximum number of parallel uploads for the upload tasks.
/// For streaming publishing, 20 is used as the most optimal.
/// For non-streaming publishing, 16 is used (there are multiple sets of 16-parallel uploads)
///
/// NOTE: Due to the desire to run on hosted agents and drastic memory changes in these VMs
/// (see https://github.com/dotnet/core-eng/issues/13098 for details) these numbers are
/// currently reduced below optimal to prevent OOM.
/// </summary>
public int MaxClients { get { return UseStreamingPublishing ? StreamingPublishingMaxClients : NonStreamingPublishingMaxClients; } }

Expand Down