[API Compat] Fix attribute comparison in type members #7376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlakollo
approved these changes
May 12, 2021
tlakollo
left a comment
tlakollo
left a comment
There was a problem hiding this comment.
Thanks for debugging this Santiago!
Member
Author
|
@missymessa FYI this will be breaking dotnet/runtime. I will be putting a PR to fix the break on dotnet/runtime. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding support to diff attributes on parameters and type parameters: 45a923c I regressed the attribute checking on type members (methods, properties, fields, etc).
This fixes that issue and adds a test to cover that scenario.
This was found as many PRs that expected to be failing didn't fail, i.e: dotnet/runtime#50894
Once this is merged I will get this flowing to dotnet/runtime and fix whatever issues were introduced in that 2 month gap.
cc: @tlakollo @vitek-karas @ericstj @eerhardt @joperezr