Add more retries to symbols and sourcelink validation #7364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For sourcelink validation, this change introduces retries. For symbols validation, this change expands retry scenarios to any failure, not just 503s, as sometimes, dotnet-symbol fails with no real indication why, and we want to retry on all scenarios. Also updates the logging, and separates out the files being downloaded via dotnet-symbol to separate directories based on msdl/symweb, so we don't think we have those files on both when they only exist on one, as our method for confirming if they were downloaded just checked to see if certain paths exist.
MattGal
reviewed
May 11, 2021
Contributor
Author
|
@MattGal Can you take another look? |
MattGal
approved these changes
May 13, 2021
Member
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
Seems like it'd work, left a few more comments.
| # Maximum number of jobs to run in parallel | ||
| $MaxParallelJobs = 16 | ||
|
|
||
| $MaxRetry = 5 |
Member
There was a problem hiding this comment.
nit: This variable could be plural since it represents a count of things.
| $NumFailedLinks++ | ||
| else { | ||
| break | ||
| } |
Member
There was a problem hiding this comment.
Not touched in this PR, but looking down (~162?) there's a catch-all catch; could that log the exception it hits?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sourcelink validation, this change introduces retries.
For symbols validation, this change expands retry scenarios to any failure, not just 503s, as sometimes, dotnet-symbol fails with no real indication why, and we want to retry on all scenarios. Also updates the logging, and separates out the files being downloaded via dotnet-symbol to separate directories based on msdl/symweb, so we don't think we have those files on both when they only exist on one, as our method for confirming if they were downloaded just checked to see if certain paths exist.
Test run on runtime in validate-dotnet: https://dev.azure.com/dnceng/internal/_build/results?buildId=1131182&view=results
To double check: