Skip to content

Conversation

@epananth
Copy link
Member

@epananth epananth commented May 6, 2021

To double check:

@epananth epananth requested a review from riarenas May 6, 2021 16:31
Copy link
Contributor

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use Stopwatch instead of DateTime subtraction for our timing

@epananth epananth requested a review from riarenas May 6, 2021 17:34
Copy link
Contributor

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any example builds? Just to see how readable the logs are with these changes

@epananth
Copy link
Member Author

epananth commented May 6, 2021

Running a build now https://dnceng.visualstudio.com/internal/_build/results?buildId=1126019&view=results, I will post the log here after this completes

@epananth
Copy link
Member Author

epananth commented May 6, 2021

image

@epananth
Copy link
Member Author

epananth commented May 6, 2021

image
downloading times are not that interesting

@riarenas
Copy link
Contributor

riarenas commented May 6, 2021

I think it would be nice to not lose the decimals in the seconds.

@epananth
Copy link
Member Author

epananth commented May 6, 2021

Yeah all the downloads were 0 seconds :D , made sure we have decimals for time taken

@epananth epananth merged commit f1e67a4 into dotnet:main May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants