Skip to content

Limit the version range for the VS generator to versions that CMake currently understands. #7342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkoritzinsky merged 1 commit into from
May 6, 2021
Merged

Limit the version range for the VS generator to versions that CMake currently understands. #7342

jkoritzinsky merged 1 commit into from
May 6, 2021

Conversation

@jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented May 4, 2021

Fixes #7324

@jkoritzinsky jkoritzinsky requested a review from RussKie May 4, 2021 17:25
@jkoritzinsky jkoritzinsky mentioned this pull request May 6, 2021
Closed
MattGal
MattGal approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoritzinsky jkoritzinsky merged commit 3094203 into dotnet:main May 6, 2021
@jkoritzinsky jkoritzinsky deleted the vs-generator-version-range branch May 6, 2021 21:14
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattGal MattGal MattGal approved these changes

@RussKie RussKie Awaiting requested review from RussKie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Unable to determine the correct CMake Generator for Visual Studio"

2 participants

@jkoritzinsky @MattGal