Skip to content

Skip the remote executor tests #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexperovich merged 1 commit into from
May 3, 2021
Merged

Skip the remote executor tests #7321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/Microsoft.DotNet.RemoteExecutor/tests/RemoteExecutorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using Microsoft.DotNet.RemoteExecutor;
using System.Diagnostics;
using System.Threading.Tasks;

using Xunit;
using Xunit.Abstractions;
using Xunit.Sdk;

namespace Microsoft.DotNet.RemoteExecutor.Tests
{
public class RemoteExecutorTests
{
[Fact]
[Fact(Skip = "Remote executor is broken in VS test explorer")]
Copy link
Member

@MattGal MattGal Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this not disable it from normal console execution?

Copy link
Contributor

@ChadNedzlek ChadNedzlek Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that even possible?

Copy link
Member Author

@alexperovich alexperovich Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its only possible by basically rewriting swaths of xunit to make a custom Fact attribute.

Copy link
Member

@MattGal MattGal Apr 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought runtime did this all the time using some kind of extension pattern. Just seems like perma-skip = never run and I understand they pass outside of VS.

Copy link
Contributor

@ChadNedzlek ChadNedzlek Apr 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime has a huge swath of custom fact stuff that I don't think we want to duplicate just to deal with these handful of tests. :-)

public void AsyncAction_ThrowException()
{
Assert.Throws<RemoteExecutionException>(() =>
Expand All @@ -24,7 +22,7 @@ public void AsyncAction_ThrowException()
);
}

[Fact]
[Fact(Skip = "Remote executor is broken in VS test explorer")]
public void AsyncAction()
{
RemoteExecutor.Invoke(async () =>
Expand All @@ -33,7 +31,7 @@ public void AsyncAction()
}, new RemoteInvokeOptions { RollForward = "Major" }).Dispose();
}

[Fact]
[Fact(Skip = "Remote executor is broken in VS test explorer")]
public void AsyncFunc_ThrowException()
{
Assert.Throws<RemoteExecutionException>(() =>
Expand All @@ -46,7 +44,7 @@ public void AsyncFunc_ThrowException()
);
}

[Fact]
[Fact(Skip = "Remote executor is broken in VS test explorer")]
public void AsyncFunc_InvalidReturnCode()
{
Assert.Throws<TrueException>(() =>
Expand All @@ -58,7 +56,7 @@ public void AsyncFunc_InvalidReturnCode()
);
}

[Fact]
[Fact(Skip = "Remote executor is broken in VS test explorer")]
public void AsyncFunc_NoThrow_ValidReturnCode()
{
RemoteExecutor.Invoke(async () =>
Expand Down