Skip to content

Add property & event support to NotSupportedAssemblyGenerator #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrabYourPitchforks merged 1 commit into from
May 3, 2021
Merged

Add property & event support to NotSupportedAssemblyGenerator #7320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/Microsoft.DotNet.GenFacades/NotSupportedAssemblyGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,22 @@ public override SyntaxNode VisitMethodDeclaration(MethodDeclarationSyntax node)
return node.WithBody(block);
}

public override SyntaxNode VisitPropertyDeclaration(PropertyDeclarationSyntax node)
{
if (_exclusionApis != null && _exclusionApis.Contains(GetPropertyDefinition(node)))
return null;

return base.VisitPropertyDeclaration(node);
}

public override SyntaxNode VisitEventDeclaration(EventDeclarationSyntax node)
{
if (_exclusionApis != null && _exclusionApis.Contains(GetEventDefinition(node)))
return null;

return base.VisitEventDeclaration(node);
}

public override SyntaxNode VisitClassDeclaration(ClassDeclarationSyntax node)
{
if (_exclusionApis != null && _exclusionApis.Contains(GetFullyQualifiedName(node)))
Expand Down Expand Up @@ -194,7 +210,11 @@ private string GetFullyQualifiedName(TypeDeclarationSyntax node)
private string GetFullyQualifiedName(NamespaceDeclarationSyntax node) => node.Name.ToFullString().Trim();

private string GetMethodDefinition(MethodDeclarationSyntax node) => GetFullyQualifiedName((TypeDeclarationSyntax)node.Parent) + "." + node.Identifier.ValueText;


private string GetPropertyDefinition(PropertyDeclarationSyntax node) => GetFullyQualifiedName((TypeDeclarationSyntax)node.Parent) + "." + node.Identifier.ValueText;

private string GetEventDefinition(EventDeclarationSyntax node) => GetFullyQualifiedName((TypeDeclarationSyntax)node.Parent) + "." + node.Identifier.ValueText;

private string GetDefaultMessage() => "{ throw new System.PlatformNotSupportedException(" + $"{ _message }); " + " }\n";
}
}