Skip to content

Add parallelism to publishing #7317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmitche merged 18 commits into from
May 3, 2021
Merged

Add parallelism to publishing #7317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b8bee6b
set max to 16
epananth Apr 27, 2021
28c498a
minor fix
epananth Apr 27, 2021
064a64e
minor fix
epananth Apr 27, 2021
ed90720
sdk
epananth Apr 27, 2021
be96dd7
release correct way
epananth Apr 27, 2021
62ce4cc
sdk
epananth Apr 28, 2021
1998f21
test
epananth Apr 28, 2021
cc3a8f1
test
epananth Apr 28, 2021
1b24382
sdk:
epananth Apr 28, 2021
4e57378
revert test changes
epananth Apr 28, 2021
474bf09
max 12
epananth Apr 28, 2021
152e4cd
max-20
epananth Apr 28, 2021
b0e5637
max 20
epananth Apr 28, 2021
7cbc0fa
Add comments
epananth Apr 29, 2021
9d4b07b
remove param chopping
epananth Apr 29, 2021
890305d
minor fix
epananth Apr 29, 2021
3f701da
review comment
epananth Apr 29, 2021
02672d0
remove stuff
epananth Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PublishToSymbolServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public void TemporarySymbolDirectoryDoesNotExists()
};
var path = TestInputs.GetFullPath("Symbol");
var buildAsset = new Dictionary<string, HashSet<Asset>>();
var publish = task.HandleSymbolPublishingAsync(path, MsdlToken, SymWebToken, "", false, buildAsset, path);
var publish = task.HandleSymbolPublishingAsync(path, MsdlToken, SymWebToken, "", false, buildAsset, null, path);
Assert.True(task.Log.HasLoggedErrors);
}

Expand Down
7 changes: 0 additions & 7 deletions src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,6 @@ public class PublishArtifactsInManifest : MSBuildTaskBase
[Required]
public string BuildAssetRegistryToken { get; set; }

/// <summary>
/// Maximum number of parallel uploads for the upload tasks
/// </summary>
public int MaxClients { get; set; } = 16;

/// <summary>
/// Directory where "nuget.exe" is installed. This will be used to publish packages.
/// </summary>
Expand Down Expand Up @@ -331,7 +326,6 @@ internal PublishArtifactsInManifestBase ConstructPublishingV2Task(BuildModel bui
BARBuildId = this.BARBuildId,
MaestroApiEndpoint = this.MaestroApiEndpoint,
BuildAssetRegistryToken = this.BuildAssetRegistryToken,
MaxClients = this.MaxClients,
NugetPath = this.NugetPath,
InternalBuild = this.InternalBuild,
SkipSafetyChecks = this.SkipSafetyChecks,
Expand Down Expand Up @@ -359,7 +353,6 @@ internal PublishArtifactsInManifestBase ConstructPublishingV3Task(BuildModel bui
BARBuildId = this.BARBuildId,
MaestroApiEndpoint = this.MaestroApiEndpoint,
BuildAssetRegistryToken = this.BuildAssetRegistryToken,
MaxClients = this.MaxClients,
NugetPath = this.NugetPath,
InternalBuild = this.InternalBuild,
SkipSafetyChecks = this.SkipSafetyChecks,
Expand Down
Loading