Skip to content

Don't fail if AzdoApiToken or ArtifactsBasePath are empty if UseStreamingPublishing is false #7308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmitche merged 1 commit into from
Apr 28, 2021
Merged

Don't fail if AzdoApiToken or ArtifactsBasePath are empty if UseStreamingPublishing is false #7308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,14 @@ public abstract class PublishArtifactsInManifestBase : Microsoft.Build.Utilities

private readonly string AzureDevOpsBaseUrl = $"https://dev.azure.com";

/// <summary>
/// Instead of relying on pre-downloaded artifacts, 'stream' artifacts in from the input build.
/// Artifacts are downloaded one by one from the input build, and then immediately published and deleted.
/// This allows for faster publishing by utilizing both upload and download pipes at the same time,
/// and reduces maximum disk usage.
/// This is not appplicable if the input build does not contain the artifacts for publishing
/// (e.g. when publishing post-build signed assets)
/// </summary>
public bool UseStreamingPublishing { get; set; }

public readonly Dictionary<TargetFeedContentType, HashSet<TargetFeedConfig>> FeedConfigs =
Expand Down Expand Up @@ -1853,14 +1861,14 @@ protected bool AnyMissingRequiredBaseProperties()
Log.LogError($"The property {nameof(BuildAssetRegistryToken)} is required but doesn't have a value set.");
}

if (string.IsNullOrEmpty(AzdoApiToken))
if (UseStreamingPublishing && string.IsNullOrEmpty(AzdoApiToken))
{
Log.LogError($"The property {nameof(AzdoApiToken)} is required but doesn't have a value set.");
Log.LogError($"The property {nameof(AzdoApiToken)} is required when using streaming publishing, but doesn't have a value set.");
}

if (string.IsNullOrEmpty(ArtifactsBasePath))
if (UseStreamingPublishing && string.IsNullOrEmpty(ArtifactsBasePath))
{
Log.LogError($"The property {nameof(ArtifactsBasePath)} is required but doesn't have a value set.");
Log.LogError($"The property {nameof(ArtifactsBasePath)} is required when using streaming publishing, but doesn't have a value set.");
}
return Log.HasLoggedErrors;
}
Expand Down