Skip to content

Conversation

@alexperovich
Copy link
Member

Setting these variables adds more isolation for dotnet commands reducing the impact of machine wide problems.

@alexperovich alexperovich added the auto-merge Automatically merge PR once CI passes. label Apr 23, 2021
@ghost
Copy link

ghost commented Apr 23, 2021

Hello @alexperovich!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@dougbu
Copy link
Contributor

dougbu commented Apr 23, 2021

Unfortunately, once this goes in and reaches dotnet/aspnetcore, we should probably ignore the change. Too many tests expect the tools to be found in the current directory. Maybe we could bite the bullet but it's not as simple as changing a few lines in our Helix scripts and TestRunner.

@ghost ghost merged commit 1b17d7c into dotnet:main Apr 23, 2021
@alexperovich alexperovich deleted the setMoreVariables branch April 24, 2021 00:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Automatically merge PR once CI passes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants