Emit the hostArchitectures attribute when building the macOS bundle.

[jkoritzinsky]

@sdmaclea can you validate that this change allows us to build an ARM64 distribution bundle on non Big Sur MacOS machines?

Contributes to dotnet/runtime#48388

Fixes #7233

[sdmaclea]

That change looks almost correct. The attribute is hostArchitectures, note the final s

I don't know how to check this works correctly, so only visually inspected.

I also don't know how to test this on my machine easily. Since Rosetta is already installed. I guess I would have to figure out how to remove it....

I think we will eventually want to set os-version min to 11.3 for Apple Silicon, because 11.2 and earlier are horribly unstable.

[jkoritzinsky]

The best way to test this would be to build Arcade locally and set the MicrosoftDotNetBuildTasksInstallersTaskAssembly msbuild property in your build to point to the locally built task assembly (for example $(ArcadeRepoRoot)/artifacts/bin/Microsoft.Dotnet.Build.Tasks.Installers/Debug/netcoreapp3.1/publish/Microsoft.DotNet.Build.Tasks.Installers.dll where $(ArcadeRepoRoot) is the root of your local Arcade clone).

[sdmaclea]

I built this on my M1, the generated Distribution file looks correct.

    <options customize="never" require-scripts="false" hostArchitectures="arm64"/>
    <welcome file="welcome.html" mime-type="text/html"/>
    <conclusion file="conclusion.html" mime-type="text/html"/>
    <volume-check>
        <allowed-os-versions>
            <os-version min="10.13"/>
        </allowed-os-versions>
    </volume-check>

It even worked when there was already a hostArchitectures attribute present. Perhaps it shouldn't overwrite it if one is actually present?

[sdmaclea]

Apple has not provided a published mechanism to uninstall Rosetta 2, so I cannot check this actually fixes the issue on my M1.

[jkoritzinsky]

It should not overwrite if the attribute is already present. It leaves the attribute as is.

[jkoritzinsky]

As the distribution file looks correct, we'll go with this until we know we need something else.