Add autocomplete PR flag for OneLocBuild template #7228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonfortescue
requested review from
ChadNedzlek,
Chrisboh,
alexperovich and
missymessa
ChadNedzlek
approved these changes
Apr 13, 2021
Contributor
ChadNedzlek
left a comment
ChadNedzlek
left a comment
There was a problem hiding this comment.
I assume the behavior of the tag is implemented elsewhere?
Contributor
Author
|
Yep! If anyone wants to turn on PR autocompletion, they need to set it to true in their build YAML. Otherwise it defaults to false (which is the right behavior since we don't want to grant the bot branch security override permissions). |
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dotnet/core-eng#12766.
Defaults turning off PR autocompletion for OneLocBuild which is what we want for security reasons.
Test runs:
CreatePris falseTo double check: