Skip to content

Conversation

@epananth
Copy link
Member

To double check:

@epananth epananth self-assigned this Apr 12, 2021
downloadType: 'specific'
itemPattern: |
PackageArtifacts/**
BlobArtifacts/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just add the missing ones below and not have the enabled:false bit?

Copy link
Contributor

@michellemcdaniel michellemcdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to remove the UseStreamingPublishing:true on row 113 until arcade promotes to itself too

@mmitche
Copy link
Member

mmitche commented Apr 12, 2021

I think I get it. This is just temporary to unblock the promotion pipeline until arcade gets a new version of publishing. Then this change will be reverted.

@michellemcdaniel
Copy link
Contributor

Nevermind on that last comment. I realized that it'll just be ignored because current arcade doesn't know about it so it should ignore it.

@epananth
Copy link
Member Author

I used a this branch to promote my changes to .Net Eng- Latest. Here is the promotion build -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1083838&view=logs&s=380ab8c6-4139-55ff-15c4-fb48260f4dca, then ran trigger subscription -> #7224 (review).

We no longer need this PR.

@epananth epananth closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants