add vs16.10 and vs.16.9 channels #6934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc: @benvillalobos |
riarenas
approved these changes
Feb 10, 2021
Contributor
riarenas
left a comment
riarenas
left a comment
There was a problem hiding this comment.
@epananth can you fill out the template https://github.com/dotnet/arcade/blob/master/Documentation/Policy/AskModeTellModeTemplate.md since this is a release branch? You'll also need approval from Matt or Mark before merging.
Member
|
I'll let @mmitche approve. (I don't see any issues) |
mmitche
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Msbuild needs these channels, I made temporary fix in msbuild post-build.yml but this will unblock them for good and they can start getting arcade updates.
Customer Impact
MSBuild builds will break,
Regression
Made the same changes in MSbuild (post-build.yml) to unblock them, that is working
Risk
How risky is this change?
Nope
Workarounds
Are there available workarounds for the bug?
For now I made the change in the repo itself, and stopped the arcade update.