Remove feed URLs in PublishToSymbolServers (release/5.0) #6702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garath
changed the title
riarenas
approved these changes
Dec 17, 2020
mmitche
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the NuGet feeds defined in the PublishToSymbolServers task. The MyGet domain will soon become invalid, and none are actually used. Instead, the package this task needs is retrieved from dotnet-eng, which is defined in the versions.props of the parent directory.
Same change in the master branch is #6691.
Customer Impact
This task is likely to fail during publishing once MyGet is shut down. NuGet will error if it tries to resolve an invalid feed URL.
Regression
No
Risk
Low. Binlogs show that the single package this task needs is actually restored from the
dotnet-engfeed. This change simply removes invalid and unused feeds.This test build shows the task succeeding with this change.
Workarounds
None.