Remove the certificate allowlist from signcheck for nupkg verification #6593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mmitche
approved these changes
Nov 19, 2020
joeloff
approved these changes
Nov 19, 2020
Contributor
Author
|
Test build failed, kind of as expected. Repos will need an arcade update to be unblocked. I'll run a second build with the arcade sdk produced by the first build and that should work. |
Contributor
Author
Contributor
Author
|
new test build with the arcade that this change will produce succeeded. Merging. dotnet/core-eng#11458 |
This was referenced Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the specific cert verification from the nupkg verifier. The NuGet team confirmed that this validation goes beyond what NuGet validates when pushing to nuget.org, and since the certs expire, maintaining this list becomes problematic for release branches.
I validated locally that adding it solves the issue seen in https://github.com/dotnet/core-eng/issues/11458 for packages signed with the new certificate.
I'll have a full arcade test build soon to validate whether this unblocks things end to end in a build.