Avoid including the validation stage if not necessary #6376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the Validation stage if both of these conditions are false: - There's an inline v2 publishing (for checking whether a channel exists) - Any post-build validation is enabled Every job dependency transition has a pretty decent cost. The stage typically takes a minute or so, and also requires getting a machine, etc. This adds up
Member
Author
|
Test build with this https://dev.azure.com/dnceng/internal/_build/results?buildId=846434&view=results |
riarenas
reviewed
Oct 9, 2020
| dependsOn: Validate | ||
| ${{ if or(eq(parameters.enableNugetValidation, 'true'), eq(parameters.enableSigningValidation, 'true'), eq(parameters.enableSourceLinkValidation, 'true'), eq(parameters.SDLValidationParameters.enable, 'true')) }}: | ||
| dependsOn: Validate | ||
| ${{ if and(ne(parameters.enableNugetValidation, 'true'), ne(parameters.enableSigningValidation, 'true'), ne(parameters.enableSourceLinkValidation, 'true'), ne(parameters.SDLValidationParameters.enable, 'true')) }}: |
Contributor
There was a problem hiding this comment.
I hate that we can't extract part of these conditions to some variable to avoid all the duplication.
riarenas
approved these changes
Oct 9, 2020
epananth
approved these changes
Oct 9, 2020
mmitche
added a commit
to mmitche/arcade
that referenced
this pull request
Oct 27, 2020
This removes the Validation stage if both of these conditions are false: - There's an inline v2 publishing (for checking whether a channel exists) - Any post-build validation is enabled Every job dependency transition has a pretty decent cost. The stage typically takes a minute or so, and also requires getting a machine, etc. This adds up
mmitche
added a commit
that referenced
this pull request
Oct 27, 2020
This removes the Validation stage if both of these conditions are false: - There's an inline v2 publishing (for checking whether a channel exists) - Any post-build validation is enabled Every job dependency transition has a pretty decent cost. The stage typically takes a minute or so, and also requires getting a machine, etc. This adds up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the Validation stage if both of these conditions are false:
Every job dependency transition has a pretty decent cost. The stage typically takes a minute or so, and also requires getting a machine, etc. This adds up