Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restorenocache environment variable when building in CI to avoid … #6237

Merged
merged 5 commits into from
Sep 23, 2020
Merged

add restorenocache environment variable when building in CI to avoid … #6237

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee6a6e7
add restorenocache environment variable when building in CI to avoid …
riarenas Sep 23, 2020
279522a
I did it backwards
riarenas Sep 23, 2020
d029d46
remove extra space
riarenas Sep 23, 2020
d4236c9
and remove comment from older iteration...
riarenas Sep 23, 2020
76b6dc7
fix the powershell script
riarenas Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eng/common/tools.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,11 +540,13 @@ function GetDefaultMSBuildEngine() {

function GetNuGetPackageCachePath() {
if ($env:NUGET_PACKAGES -eq $null) {
# Use local cache on CI to ensure deterministic build,
# Use local cache on CI to ensure deterministic build.
# Avoid using the http cache as workaround for https://github.com/NuGet/Home/issues/3116
# use global cache in dev builds to avoid cost of downloading packages.
# For directory normalization, see also: https://github.com/NuGet/Home/issues/7968
if ($useGlobalNuGetCache) {
riarenas marked this conversation as resolved.
Show resolved Hide resolved
$env:NUGET_PACKAGES = Join-Path $env:UserProfile '.nuget\packages\'
$env:RESTORENOCACHE = $true
} else {
$env:NUGET_PACKAGES = Join-Path $RepoRoot '.packages\'
}
Expand Down
3 changes: 3 additions & 0 deletions eng/common/tools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ use_installed_dotnet_cli=${use_installed_dotnet_cli:-true}
dotnetInstallScriptVersion=${dotnetInstallScriptVersion:-'v1'}

# True to use global NuGet cache instead of restoring packages to repository-local directory.
# also clear the http NuGet cache.
if [[ "$ci" == true ]]; then
use_global_nuget_cache=${use_global_nuget_cache:-false}
else
Expand Down Expand Up @@ -312,12 +313,14 @@ function InitializeBuildTool {
_InitializeBuildToolFramework="netcoreapp2.1"
}

# Set RestoreNoCache as a workaround for https://github.com/NuGet/Home/issues/3116
function GetNuGetPackageCachePath {
if [[ -z ${NUGET_PACKAGES:-} ]]; then
if [[ "$use_global_nuget_cache" == true ]]; then
export NUGET_PACKAGES="$HOME/.nuget/packages"
else
export NUGET_PACKAGES="$repo_root/.packages"
export RESTORENOCACHE=true
fi
fi

Expand Down