Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

Fixes: #6098
Related to the following Runtime PR that needs this change to work: dotnet/runtime#41698

We need to run VerifyClosure target independently of other validations. This change updates the target condition to allow this.

@ericstj
Copy link
Member

ericstj commented Sep 2, 2020

Didn't you also mention that you needed to update the task to ensure it creates the directory:

using (var file = File.Create(dependencyGraphFilePath))
{
doc.Save(file);
}

@NikolaMilosavljevic
Copy link
Member Author

Didn't you also mention that you needed to update the task to ensure it creates the directory:

using (var file = File.Create(dependencyGraphFilePath))
{
doc.Save(file);
}

There is a different issue for that fix: #6090

I tried to minimize amount of changes in Arcade, to be able to pick up only SharedFrameworks package for RC2. Directory is being created with a new target you proposed for runtime repo.

@ericstj
Copy link
Member

ericstj commented Sep 2, 2020

Doesn't this package carry the task and you're already updating it? You can have fewer moving parts and not need a workaround that you have to remove later.

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented Sep 2, 2020

Doesn't this package carry the task and you're already updating it? You can have fewer moving parts and not need a workaround that you have to remove later.

No, unfortunately, the task is in a different package: Microsoft.DotNet.Build.Tasks.Packaging

@ericstj
Copy link
Member

ericstj commented Sep 2, 2020

Hmm, I thought that @jkoritzinsky duplicated it, but maybe that's in a later PR.

@jkoritzinsky
Copy link
Member

The duplication is in the new Shared Framework SDK at #5714 that I'm still waiting on reviews on before I can merge in.

@ericstj
Copy link
Member

ericstj commented Sep 2, 2020

Understood (my review too, apologies). I'll leave it to you @NikolaMilosavljevic to choose what you think is the least risky here.

@NikolaMilosavljevic
Copy link
Member Author

The duplication is in the new Shared Framework SDK at #5714 that I'm still waiting on reviews on before I can merge in.

Jeremy, that PR is for 6.0, right?

@jkoritzinsky
Copy link
Member

Yes that PR is for 6.0, but given the size of the change I'm hoping to get it in early in 6.0 so we can make sure that any issues that come up are solved before we start the release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow VerifyClosure target to run independently from other validations

3 participants