Add dotnet-install scripts that understand the "productVersion.txt" file #6051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of 'productVersion.txt' These become the default, but can be turned off via providing '-useDefaultDotnetInstall true' args Add Pipeline telemetry error logging exclusions for dotnet-install.* (can't tell where these will run from reliably and the things which invoke them do use the infra)
MattGal
added a commit
to MattGal/install-scripts
that referenced
this pull request
Aug 27, 2020
…ectly review; may want to actually merge after feedback
Member
Author
|
(See https://github.com/dotnet/install-scripts/pull/76/files for the delta of the install scripts) |
dougbu
reviewed
Aug 27, 2020
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
/fyi I'm going to test this out in my already hacked-up 'dougbu/5.0.0' branch in dotnet-aspnetcore
mmitche
reviewed
Aug 28, 2020
dougbu
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Aug 28, 2020
- should enable installation of 5.0.0 runtimes
dougbu
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Aug 28, 2020
- hoping this fixes the runtime installations on Windows
mmitche
approved these changes
Aug 28, 2020
mmitche
pushed a commit
to mmitche/installer
that referenced
this pull request
Sep 14, 2020
dotnet/arcade#6051 fixed the issue where the install scripts require matching names of files to directories. Remove the double publish change introduced in 3.0
mmitche
added a commit
to dotnet/installer
that referenced
this pull request
Sep 18, 2020
dotnet/arcade#6051 fixed the issue where the install scripts require matching names of files to directories. Remove the double publish change introduced in 3.0 Co-authored-by: dotnet-bot <dotnet-bot@dotnetfoundation.org>
MattGal
added a commit
to MattGal/arcade
that referenced
this pull request
Oct 29, 2020
…n.txt" file (dotnet#6051)" This reverts commit 88ce535 except for spelling errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add special versions of dotnet-install.* that understand the existence of 'productVersion.txt'. See #6047 for details.
This change works (lightly tested) for Windows now, but is a draft PR until I make the equivalent workarounds in the .sh versions.