-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent double-import warning for Microsoft.Common.props #5747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to do the same thing 😺
This.... shouldn't really be needed at all. A helix sdk project doesn't use the 'Microsoft.NET.Sdk' and projects made with the helix sdk shouldn't ever import it. |
@alexperovich without this conditionality, features such as automated .NET SDK installation on Helix agents are pretty much useless. We need to know |
I think @alexperovich is suggesting full deletion of the line. I prefer to not find out that we did actually need it later on, but I'll chat w/ Alex offline and get this done one way or the other. |
I am not suggesting full deletion of the line. The helix sdk requires microsoft.common.props and targets to work. It is not designed to work alongside another SDK that also imports them. We can add this condition, but there are no guarantees that anything will work in that scenario. |
What alternative do you suggest @alexperovich to make |
After discussion with @alexperovich it seems that it's preferable for teams needing to do this to suppress the warning, abandoning. |
Why is it preferable to suppress the warning❔ I thought @alexperovich was saying what we need to do won't work and we might as well give up on |
It looks like we can grab that version without importing the entire sdk. I will look into it. |
Much appreciated❕ |
Noted from the conversation here