RemoveOSGroup from the arcade #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anipik
requested review from
dagood,
ericstj,
safern and
ViktorHofer
and removed request for
dagood
ViktorHofer
approved these changes
Feb 25, 2020
src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/targets/installer.targets
Show resolved
Hide resolved
dagood
approved these changes
Feb 25, 2020
|
As discussed offline, please prefer using $(OS) for Windows_NT and Unix: dotnet/msbuild#2468 (comment). |
ViktorHofer
reviewed
Feb 25, 2020
| @@ -2,7 +2,7 @@ | |||
| <Project> | |||
|
|
|||
| <!-- PInvokeChecker data files--> | |||
| <PropertyGroup Condition="'$(OSGroup)'=='Windows_NT'"> | |||
| <PropertyGroup Condition="'$(OS)'=='Windows_NT'"> | |||
There was a problem hiding this comment.
nit: whitespace around the == operator :)
There was a problem hiding this comment.
I can fix this in another arcade PR :P I need this change to be in for the BuildOS change
ViktorHofer
approved these changes
Feb 25, 2020
This was referenced Feb 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSGroup is dotnet runtime specific property and should not be used in arcade.
The SharedFramework.sdk And Microsoft.Dotnet.CodeAnalysis are 2 projects that use this property.
SharedFramework.Sdk is used in -> runtime and dotnet\windowsDesktop
Microsoft.dotnet.codeanalysis is used in -> runtime, wpf, buildtools
CodeAnalysis change is restricted to pinvoke checking. I tested the change by building the runtime repo with these new packages.
Fixes #4907