Make SkipOnCoreClr skip always when running in CoreCLR if no flags specified and cache values #4724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecified and cache values
stephentoub
reviewed
Jan 31, 2020
| @@ -5,10 +5,8 @@ namespace Xunit | |||
| [Flags] | |||
| public enum RuntimeStressTestModes | |||
There was a problem hiding this comment.
Nit: Should this just be RuntimeTestModes? Then Any makes more sense, as it would include a "Release" if that were actually a named entry.
|
Will merge and prepare the necessary changes in dotnet/runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: dotnet/runtime#118 (comment) -- I'm changing
SkipOnCoreClrAttributeto only skip on checked runtime ifRuntimeStressTestModes.CheckedRuntimeis passed down.Default usage will skip in all versions of coreclr.
Also fixes: #4392
cc: @stephentoub @akoeplinger @jkotas