Add .NET package icon to all packages by default. #4074
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@wtgodbe This PR would replace dotnet/efcore#18027 |
The icon can be changed by setting PackageIconFullPath property to the full path of the desired icon. To include icon in projects with hand-written .nuspec add `$CommonFileElements$` under `<files>` element, e.g. ```xml <files> $CommonFileElements$ <file src="netcoreapp2.0\MyLib.dll" target="tools\netcoreapp2.0" /> </files> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet now recommends to include the package icon in NuGet packages instead of specifying
PackageIconUrl. This change adds the icon by default to all packages built by Arcade SDK.The icon can be changed by setting
PackageIconFullPathproperty to the full path of the desired icon.To include icon in projects with hand-written .nuspec file add
$CommonFileElements$under<files>element, e.g.