-
Notifications
You must be signed in to change notification settings - Fork 379
Don't produce CBL-Mariner 1/2-specific packages #15488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We don't ship these any more, so we can stop producing them. Contributes to dotnet#15486
|
For AzureLinux 3, we're just using the regular RPM packages we produce (which are identical to what we did for the CBL-Mariner packages as they're just copies). We aren't going to publish new packages for Mariner 1 or 2 as 1 is already out of support and 2 is going out of support before .NET 10 comes out. |
Different signing certificate was used for Mariner/AzureLinux. Not sure how that's going to work with a single package, but some changes would be needed on the signing side - @mmitche |
|
@NikolaMilosavljevic if we just need AzureLinux vs regular PMC, I can change this to instead generate one general AzureLinux package variant. |
I think that should work. Release process might need to be adjusted though - @leecow @rbhanda |
|
I presume we want to continue publishing .NET 8 for Mariner 2 until 8 is out of support? |
…extension that the Arcade SDK will recognize and sign with the special certificate.
|
I've updated this PR to instead change the naming of the files and integrate more directly with the Arcade SDK's signing support.
I'm not planning on backporting this change to .NET 8 as of now, but I wouldn't expect us to publish packages for Mariner 2 after Mariner 2 is EOL (this June, not next June). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, as long as this was validated offline in package/installer build.
@mmitche for awareness of the signing change.
We don't ship these any more, so we can stop producing them.Instead, produce a special .azl.rpm copy that's not versioned with Azure Linux (to avoid having to update this regularly) that has a configuration in Arcade to be signed with the correct certificate.
Contributes to #15486
To double check: