Apply the DefaultArtifactVisibility on ItemsToPushToBlobFeed #15425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that DefaultArtifactVisibility is currently only applied on Artifact but not on ItemsToPushToBlobFeed which some repositories use as an extension point and is the item definition that the Artifact items feed into.
jkoritzinsky
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that DefaultArtifactVisibility is currently only applied on Artifact but not on ItemsToPushToBlobFeed which some repositories use as an extension point and is the item definition that the Artifact items feed into.
Overall, when we get to the "Fit and Finish" stage of VMR, I will remove the
Artifactextension point and make the existing sign and publish items easier to use. This makes sense as we will stop importing Sign.props from Publish.proj now that we don't have post build signing infra support anymore. In the (5?) repos where we use the Artifact extension point, I plan to add a file that gets imported by Signing.props and Publishing.props (i.e. SignAndPublishArtifacts.props) that allows to keep the single definition of artifacts.