New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find slnx file #15392

Merged

edvilme merged 6 commits into main from edvilme-slnx

Jan 14, 2025

Member

edvilme commented Jan 9, 2025 •

edited

Loading

Support to finding .slnx repo solution files as part of the effort on adopting the new format.

To double check:

The right tests are in and the right validation has happened. Guidance: https://github.com/dotnet/arcade/blob/main/Documentation/Validation.md


          Find slnx file

e384eb3

ViktorHofer reviewed

View reviewed changes

src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj Outdated Show resolved Hide resolved


          Ref: PR suggestions

632daf6

edvilme requested a review from ViktorHofer

January 13, 2025 16:44

ViktorHofer reviewed

View reviewed changes

src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj Outdated Show resolved Hide resolved

ViktorHofer previously approved these changes

View reviewed changes


          Error if both sln and slnx files are found

fc0c2af

edvilme dismissed ViktorHofer’s stale review via

fc0c2af

January 13, 2025 19:46

edvilme requested a review from ViktorHofer

January 13, 2025 19:46

ViktorHofer reviewed

View reviewed changes

src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj Outdated Show resolved Hide resolved


          Move error to target

70cf9c7

ViktorHofer reviewed

View reviewed changes

src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj Outdated Show resolved Hide resolved


          Update src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj

5573c45

Co-authored-by: Viktor Hofer <[email protected]>

ViktorHofer reviewed

View reviewed changes

src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj Outdated Show resolved Hide resolved


          Update src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj

f4951fe

Co-authored-by: Viktor Hofer <[email protected]>

edvilme requested a review from ViktorHofer

January 14, 2025 19:26

ViktorHofer approved these changes

View reviewed changes

edvilme merged commit 2696b08 into main

11 checks passed

edvilme deleted the edvilme-slnx branch

January 14, 2025 19:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet