Default FullAssemblySigningSupported == false only in source-only cases #15303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, move around how this property is set: - Do not set the default in the build infra. Use strongname.props instead - No need to pass this value through globally. Global properties passed through the outer build make it into the inner build - Import strongname.props before Sign.props in Sign.proj and Publish.proj. This ensures that signing strongname settings that depend on FullAssemblySigningSupported are correct.
|
Validated using the binlog of SDK and a few local builds. |
|
Resolves #15301 |
mmitche
changed the base branch from
full-assembly-signing-unsupported-default
to
main
ViktorHofer
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, move around how this property is set:
To double check: