Move nuget from version 6.4.2 to 6.4.3 #14509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garath
approved these changes
Feb 23, 2024
|
Test failure needs investigation. Closing this PR and moving the issue to the backlog, it will need to be picked up by someone else. |
2 tasks
… are caused by this setting or by some kind of issue with the version of the SDK actually downloaded. If the issue is with the actual SDK install operation then it is expected that the 7.0.116 version of the SDK will not exist and we should see a different type of failure message like directory not found.
NOTE: When the value is hard coded all test for the CI build passed. However, I don't believe we should be hard coding this value to address the build breaks and should instead discover where the incorrect 8.0 value settings are coming from.
2 tasks
Forcing the value of DotNetCliVersion to be empty to see how the system behaves if valid package type is set or there is no known version information for the package type parameter is passed in. The expectation is having a empty value will result in some kind of null reference error when trying to access .Net Core SDK data. If the value does not control the actual SDK install and or use it will also let us know if the version test script that is failing is doing a simple string comparison as opposed to examining the actual SDK being used. If it IS doing a simple string comparison the expectation is that the output of the failure will not show an empty value for the current .Net CORE SDK in the mismatch error rather than SDK version that is actually installed.
…t trigger an automatic CI build.
Hard Coding DotNetCliVersion for SDK package types to '7.0.116'. Because hard coding the value for RUNTIM package types failed with the same version mismatch error the expectation is that this CI build should pass all tests, which will confirm that the root issue is the passed in value for NETCoreSdkVersion.
…Type is set to SDK to restore the DotNetCli.props file to its original state. Based on the tests performed the bad .Net Core SDK state occurs when the this props file is used with the DotNetCliPackageType set to SDK and NETCoreSdkVersion set to 8.0.200.
3 tasks
… for SDK packages per guidance from Christopher Costa
dougbu
reviewed
Feb 29, 2024
global.json
Outdated
| @@ -1,4 +1,8 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "7.0.116", | |||
| "rollForward": "disable" | |||
There was a problem hiding this comment.
nit, to be more consistent w/ at least release/6.0 (where we've avoided this issue):
Suggested change
| "rollForward": "disable" | |
| "rollForward": "latestFeature" |
There was a problem hiding this comment.
I also suggest porting this update to release/8.0 and main. we'll be scratching our heads again too soon otherwise
…be consistent with other branch settings based on guidance from Christopher Costa.
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validated with https://dev.azure.com/dnceng/internal/_build/results?buildId=2385899&view=results
Fixes dotnet/dnceng#2022
To double check: