[release/8.0] Bump a few package versions #14190
Conversation
- small part of dotnet/dnceng#345 - was dotnet#14003 in main but could use Directory.Packages.props there - bring System.Security.Cryptography.Xml v6.0.1 in directly - see dotnet/dnceng#1207 - useful wherever Microsoft.Build.Tasks.Core is used - react to deprecation of `ContentItemCollection.FindItemGroups(...)`
dougbu
force-pushed
the
dougbu/backport.14003.1320
branch
from
41eba36 to
f043ad2
Compare
|
/ping reviewers: this is ready to go @ViktorHofer note I'm again not bumping the Microsoft.Build* packages. here, it's mostly to avoid a bigger change (affecting more packages) than necessary |
|
Yes, we shouldn't change major/minor versions of the Microsoft.Build packages in servicing. |
| <!-- Upgrade System.Security.Cryptography.Xml/6.0.0 which is referenced by Microsoft.Build.Tasks.Core. --> | ||
| <PackageReference Include="System.Security.Cryptography.Xml" Version="$(SystemSecurityCryptographyXmlVersion)" /> |
There was a problem hiding this comment.
This results in a package dependency added to the produced nuget package. Is that intentional?
There was a problem hiding this comment.
not exactly intentional but hard to avoid. compensating factor (to some extent): the "added" package dependency was brought into consuming projects beforehand — just transitively
There was a problem hiding this comment.
also, this has no impact on our product since no project in this repo produces shipping packages
- see dotnet/dnceng#1207 - somehow missed two projects in dotnet#14190
- see dotnet/dnceng#1207 - somehow missed two projects in #14190
2 participants
ContentItemCollection.FindItemGroups(...)To double check: