[release/7.0] Bump a few package versions #14001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- small part of dotnet/dnceng#345 - bump Azure.Data.Tables to v12.8.1 - replace Microsoft.IdentityModel.Clients.ActiveDirectory with Microsoft.Identity.Client - part of dotnet/dnceng#629 - bump NuGet.* to v6.7.0 - part of https://dev.azure.com/dnceng/internal/_workitems/edit/5127 - part of https://dev.azure.com/dnceng/internal/_workitems/edit/5128 - part of https://dev.azure.com/dnceng/internal/_workitems/edit/5129 - part of https://dev.azure.com/dnceng/internal/_workitems/edit/5137 - left both `$(NuGetVersioningVersion)` and `$(NuGetVersion)` to minimize disruption - see dotnet#12333 change in 'main' for a counter-example - react to deprecation of `ContentItemCollection.FindItemGroups(...)` - react to removal of `SignatureVerificationProviderFactory` - react to `VerifySignaturesResult` API changes (`Valid` to `IsValid`) - bump NewtonSoft.Json to v13.0.3 - nits: - remove unused `$(...Version)` properties - remove a bit of dead code and unused `using`s in changed files
Contributor
Author
|
see #14000 for a few comments in the changes |
joeloff
reviewed
Aug 30, 2023
| } | ||
|
|
||
| // This method and SignatureVerificationResult.IsSigned are slightly misnamed. Signature validity is just as | ||
| // important as signature existence. The new VerifySignatureResult.IsSigned property would _not_ be correct |
Member
There was a problem hiding this comment.
IsSigned implies a valid signature, That's what the tool originally did. Did NuGet change their APIs? We never checked for the existence of a signature, we checked that the signature was valid. Anything else and it returned false so the file can be flagged.
The process of verifying it however is deferred to NuGet libraries
Contributor
Author
There was a problem hiding this comment.
yes and yes. this comment is just warning future Doug (or similar) not to use the new NuGet IsSigned property despite the name alignment. NuGet also changed Valid to IsValid, fortunately w/o changing semantics
1 task
mmitche
approved these changes
Sep 14, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(NuGetVersioningVersion)and$(NuGetVersion)to minimize disruptionContentItemCollection.FindItemGroups(...)SignatureVerificationProviderFactoryVerifySignaturesResultAPI changes (ValidtoIsValid)$(...Version)propertiesusings in changed filesTo double check: