Skip to content

Conversation

@vlada-shubina
Copy link
Member

@vlada-shubina vlada-shubina commented Jan 24, 2023

Background: now with xunit/xunit#2073 it is possible to skip unit tests programmatically and this way works in VS, CI, etc.

There are common attributes that repos write usually based on platform and/or target framework, sometimes even more the once.
Microsoft.DotNet.XUnitExtensions looks like the common extensions provide by arcade and will be a better place for it, so that all repos that use arcade can use it too.

Repos that can benefit from it:
https://github.com/dotnet/sdk/blob/a30e465a2e2ea4e2550f319a2dc088daaafe5649/src/Tests/Microsoft.NET.TestFramework/Attributes/WindowsOnlyFactAttribute.cs
https://github.com/dotnet/installer/blob/8c476b58df6032c6713c69535d2679632abac9ba/test/Microsoft.DotNet.Tools.Tests.Utilities/WindowsOnlyFactAttribute.cs
https://github.com/dotnet/command-line-api/blob/72e86ec7615c0c8ecb6a13e34a5c0a97e9309909/src/System.CommandLine.Tests/Utility/WindowsOnlyFactAttribute.cs

@vlada-shubina vlada-shubina force-pushed the fact-theory-attributes branch from bcb7b7b to 601f789 Compare February 1, 2023 10:13
@akoeplinger akoeplinger merged commit 4f24936 into dotnet:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants