Skip to content

Fix the target framework in the msi.proj now that net5.0 is unsupported by the sdk #11284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Fix the target framework in the msi.proj now that net5.0 is unsupported by the sdk #11284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.DotNet.Build.Tasks.Workloads/src/Misc/msi.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<PackageType>DotnetPlatform</PackageType>
<PackageVersion>__PACKAGE_VERSION__</PackageVersion>
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
Copy link
Member

@akoeplinger akoeplinger Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing should we make this a __TARGET_FRAMEWORK__ argument so that it can be passed in?

Copy link
Member

@joeloff joeloff Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(TargetFramework) would be better since this is a template for a .csproj and you don't know up front under which build the project will be invoked. If it's a property, consumers can pass valid values and we can try to calculate a defualt.

</PropertyGroup>

<ItemGroup>
Expand Down