Skip to content

Conversation

@dagood
Copy link
Member

@dagood dagood commented Jul 22, 2022

In #7611, I added a way to pass AzDOBuildId etc. into eng/common/templates/job/execute-sdl.yml so the template works for non-BAR scenarios like mine (microsoft/go). It looks like this broke in some refactor PRs, and now the Maestro/BAR-based setup-maestro-vars.yml runs unconditionally.

The template still has these:

    - name: AzDOBuildId
      value: ${{ parameters.AzDOBuildId }}

So, all I had to do in this PR was make setup-maestro-vars.yml conditional. 🙂

The change works in my build. I'm not sure if any more testing is necessary: nobody else sets these template parameters (I did some searching in dotnet), and the change is pretty simple.

@adiaaida, @garath, can you take a look, or loop in more people involved in Guardian/SDL currently?


To double check:

@dagood dagood merged commit c670c5b into dotnet:main Sep 13, 2022
@dagood dagood deleted the dev/dagood/sdl-fed branch September 13, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants