-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OctoKit to 10.0.0
#3333
Bump OctoKit to 10.0.0
#3333
Conversation
…d 20240222.1 CoreHealthMonitor , Microsoft.AspNetCore.ApiPagination , Microsoft.AspNetCore.ApiVersioning , Microsoft.AspNetCore.ApiVersioning.Analyzers , Microsoft.AspNetCore.ApiVersioning.Swashbuckle , Microsoft.DncEng.CommandLineLib , Microsoft.DncEng.Configuration.Extensions , Microsoft.DotNet.Authentication.Algorithms , Microsoft.DotNet.GitHub.Authentication , Microsoft.DotNet.Internal.DependencyInjection , Microsoft.DotNet.Internal.DependencyInjection.Testing , Microsoft.DotNet.Internal.Health , Microsoft.DotNet.Internal.Logging , Microsoft.DotNet.Internal.Testing.DependencyInjection.Abstractions , Microsoft.DotNet.Internal.Testing.DependencyInjectionCodeGen , Microsoft.DotNet.Internal.Testing.Utility , Microsoft.DotNet.Kusto , Microsoft.DotNet.Metrics , Microsoft.DotNet.ServiceFabric.ServiceHost , Microsoft.DotNet.Services.Utility , Microsoft.DotNet.Web.Authentication , ServiceFabricMocks From Version 1.1.0-beta.24115.1 -> To Version 1.1.0-beta.24122.1
…d 20240222.2 CoreHealthMonitor , Microsoft.AspNetCore.ApiPagination , Microsoft.AspNetCore.ApiVersioning , Microsoft.AspNetCore.ApiVersioning.Analyzers , Microsoft.AspNetCore.ApiVersioning.Swashbuckle , Microsoft.DncEng.CommandLineLib , Microsoft.DncEng.Configuration.Extensions , Microsoft.DotNet.Authentication.Algorithms , Microsoft.DotNet.GitHub.Authentication , Microsoft.DotNet.Internal.DependencyInjection , Microsoft.DotNet.Internal.DependencyInjection.Testing , Microsoft.DotNet.Internal.Health , Microsoft.DotNet.Internal.Logging , Microsoft.DotNet.Internal.Testing.DependencyInjection.Abstractions , Microsoft.DotNet.Internal.Testing.DependencyInjectionCodeGen , Microsoft.DotNet.Internal.Testing.Utility , Microsoft.DotNet.Kusto , Microsoft.DotNet.Metrics , Microsoft.DotNet.ServiceFabric.ServiceHost , Microsoft.DotNet.Services.Utility , Microsoft.DotNet.Web.Authentication , ServiceFabricMocks From Version 1.1.0-beta.24115.1 -> To Version 1.1.0-beta.24122.2
- see dotnet/dnceng#2065 - comment about Octokit.dll not being signed is no longer true (since v4.0.0) - still need to avoid signing Microsoft.DotNet.Maestro.Tasks.dll for other reasons
11d9563
to
f3ee316
Compare
doubt the bot can merge this due to my added commit. please approve 😁 |
…d 20240222.2 CoreHealthMonitor , Microsoft.AspNetCore.ApiPagination , Microsoft.AspNetCore.ApiVersioning , Microsoft.AspNetCore.ApiVersioning.Analyzers , Microsoft.AspNetCore.ApiVersioning.Swashbuckle , Microsoft.DncEng.CommandLineLib , Microsoft.DncEng.Configuration.Extensions , Microsoft.DotNet.Authentication.Algorithms , Microsoft.DotNet.GitHub.Authentication , Microsoft.DotNet.Internal.DependencyInjection , Microsoft.DotNet.Internal.DependencyInjection.Testing , Microsoft.DotNet.Internal.Health , Microsoft.DotNet.Internal.Logging , Microsoft.DotNet.Internal.Testing.DependencyInjection.Abstractions , Microsoft.DotNet.Internal.Testing.DependencyInjectionCodeGen , Microsoft.DotNet.Internal.Testing.Utility , Microsoft.DotNet.Kusto , Microsoft.DotNet.Metrics , Microsoft.DotNet.ServiceFabric.ServiceHost , Microsoft.DotNet.Services.Utility , Microsoft.DotNet.Web.Authentication , ServiceFabricMocks From Version 1.1.0-beta.24115.1 -> To Version 1.1.0-beta.24122.2
src/Maestro/Microsoft.DotNet.Maestro.Tasks/Microsoft.DotNet.Maestro.Tasks.csproj
Show resolved
Hide resolved
10.0.0
Based on https://github.blog/changelog/2021-10-14-rest-api-preview-promotions/ I removed the non-existent header |
The signing triggers a cascade of problems down the line. I will deal with that separately, let's just bump now and get it in |
right, I had tried that before and restored the opt-out as a result. removed the comment b/c it wasn't correct and "to be consistent with every other non-test project" seemed useless. might have filed a follow-up after testing locally to see if everything worked without any opt-outs but it wasn't an immediate priority |
dotnet/dnceng#2065
From https://github.com/dotnet/dnceng-shared
Release Note Category
Release Note Description
Update the
OctoKit.NET
library from0.49.0
to10.0.0