Bump OctoKit to 10.0.0
#3333
Merged
Bump OctoKit to 10.0.0
#3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…d 20240222.1 CoreHealthMonitor , Microsoft.AspNetCore.ApiPagination , Microsoft.AspNetCore.ApiVersioning , Microsoft.AspNetCore.ApiVersioning.Analyzers , Microsoft.AspNetCore.ApiVersioning.Swashbuckle , Microsoft.DncEng.CommandLineLib , Microsoft.DncEng.Configuration.Extensions , Microsoft.DotNet.Authentication.Algorithms , Microsoft.DotNet.GitHub.Authentication , Microsoft.DotNet.Internal.DependencyInjection , Microsoft.DotNet.Internal.DependencyInjection.Testing , Microsoft.DotNet.Internal.Health , Microsoft.DotNet.Internal.Logging , Microsoft.DotNet.Internal.Testing.DependencyInjection.Abstractions , Microsoft.DotNet.Internal.Testing.DependencyInjectionCodeGen , Microsoft.DotNet.Internal.Testing.Utility , Microsoft.DotNet.Kusto , Microsoft.DotNet.Metrics , Microsoft.DotNet.ServiceFabric.ServiceHost , Microsoft.DotNet.Services.Utility , Microsoft.DotNet.Web.Authentication , ServiceFabricMocks From Version 1.1.0-beta.24115.1 -> To Version 1.1.0-beta.24122.1
…d 20240222.2 CoreHealthMonitor , Microsoft.AspNetCore.ApiPagination , Microsoft.AspNetCore.ApiVersioning , Microsoft.AspNetCore.ApiVersioning.Analyzers , Microsoft.AspNetCore.ApiVersioning.Swashbuckle , Microsoft.DncEng.CommandLineLib , Microsoft.DncEng.Configuration.Extensions , Microsoft.DotNet.Authentication.Algorithms , Microsoft.DotNet.GitHub.Authentication , Microsoft.DotNet.Internal.DependencyInjection , Microsoft.DotNet.Internal.DependencyInjection.Testing , Microsoft.DotNet.Internal.Health , Microsoft.DotNet.Internal.Logging , Microsoft.DotNet.Internal.Testing.DependencyInjection.Abstractions , Microsoft.DotNet.Internal.Testing.DependencyInjectionCodeGen , Microsoft.DotNet.Internal.Testing.Utility , Microsoft.DotNet.Kusto , Microsoft.DotNet.Metrics , Microsoft.DotNet.ServiceFabric.ServiceHost , Microsoft.DotNet.Services.Utility , Microsoft.DotNet.Web.Authentication , ServiceFabricMocks From Version 1.1.0-beta.24115.1 -> To Version 1.1.0-beta.24122.2
This was referenced Feb 23, 2024
- see dotnet/dnceng#2065 - comment about Octokit.dll not being signed is no longer true (since v4.0.0) - still need to avoid signing Microsoft.DotNet.Maestro.Tasks.dll for other reasons
dougbu
force-pushed
the
darc-main-34ae2df5-12fa-4470-88f5-cfe19fa63458
branch
from
11d9563
to
f3ee316
Compare
dougbu
requested review from
garath,
AlitzelMendez,
premun,
epananth,
dkurepa and
a team
|
doubt the bot can merge this due to my added commit. please approve 😁 |
…d 20240222.2 CoreHealthMonitor , Microsoft.AspNetCore.ApiPagination , Microsoft.AspNetCore.ApiVersioning , Microsoft.AspNetCore.ApiVersioning.Analyzers , Microsoft.AspNetCore.ApiVersioning.Swashbuckle , Microsoft.DncEng.CommandLineLib , Microsoft.DncEng.Configuration.Extensions , Microsoft.DotNet.Authentication.Algorithms , Microsoft.DotNet.GitHub.Authentication , Microsoft.DotNet.Internal.DependencyInjection , Microsoft.DotNet.Internal.DependencyInjection.Testing , Microsoft.DotNet.Internal.Health , Microsoft.DotNet.Internal.Logging , Microsoft.DotNet.Internal.Testing.DependencyInjection.Abstractions , Microsoft.DotNet.Internal.Testing.DependencyInjectionCodeGen , Microsoft.DotNet.Internal.Testing.Utility , Microsoft.DotNet.Kusto , Microsoft.DotNet.Metrics , Microsoft.DotNet.ServiceFabric.ServiceHost , Microsoft.DotNet.Services.Utility , Microsoft.DotNet.Web.Authentication , ServiceFabricMocks From Version 1.1.0-beta.24115.1 -> To Version 1.1.0-beta.24122.2
AlitzelMendez
previously approved these changes
Feb 23, 2024
premun
reviewed
Feb 23, 2024
src/Maestro/Microsoft.DotNet.Maestro.Tasks/Microsoft.DotNet.Maestro.Tasks.csproj
Show resolved
Hide resolved
premun
changed the title
10.0.0
|
Based on https://github.blog/changelog/2021-10-14-rest-api-preview-promotions/ I removed the non-existent header |
premun
previously approved these changes
Feb 23, 2024
dkurepa
previously approved these changes
Feb 23, 2024
|
The signing triggers a cascade of problems down the line. I will deal with that separately, let's just bump now and get it in |
dkurepa
approved these changes
Feb 23, 2024
dotnet-maestro
bot
deleted the
darc-main-34ae2df5-12fa-4470-88f5-cfe19fa63458
branch
right, I had tried that before and restored the opt-out as a result. removed the comment b/c it wasn't correct and "to be consistent with every other non-test project" seemed useless. might have filed a follow-up after testing locally to see if everything worked without any opt-outs but it wasn't an immediate priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/dnceng#2065
From https://github.com/dotnet/dnceng-shared
Release Note Category
Release Note Description
Update the
OctoKit.NETlibrary from0.49.0to10.0.0