[Mono.Android] update more TypeManager.GetClassName() calls
#9865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Mono.Android` has various test failures under NativeAOT such as:
02-28 16:35:29.583 18438 18456 I NUnit : CastJavaLangObjectArrayToByteArrayThrows
02-28 16:35:29.586 18438 18456 E NUnit : [FAIL]
02-28 16:35:29.586 18438 18456 E NUnit : : Expected: <System.InvalidCastException>
02-28 16:35:29.586 18438 18456 E NUnit : But was: <System.DllNotFoundException> (DllNotFound_Linux, xa-internal-api,
02-28 16:35:29.586 18438 18456 E NUnit : dlopen failed: library "xa-internal-api.so" not found
02-28 16:35:29.586 18438 18456 E NUnit : dlopen failed: library "libxa-internal-api.so" not found
02-28 16:35:29.586 18438 18456 E NUnit : dlopen failed: library "xa-internal-api" not found
02-28 16:35:29.586 18438 18456 E NUnit : dlopen failed: library "libxa-internal-api" not found
02-28 16:35:29.586 18438 18456 E NUnit : )
02-28 16:35:29.586 18438 18456 E NUnit : at System.Runtime.InteropServices.NativeLibrary.LoadLibErrorTracker.Throw(String) + 0x4c
02-28 16:35:29.586 18438 18456 E NUnit : at Internal.Runtime.CompilerHelpers.InteropHelpers.FixupModuleCell(InteropHelpers.ModuleFixupCell*) + 0x134
02-28 16:35:29.586 18438 18456 E NUnit : at Internal.Runtime.CompilerHelpers.InteropHelpers.ResolvePInvokeSlow(InteropHelpers.MethodFixupCell*) + 0x40
02-28 16:35:29.586 18438 18456 E NUnit : at Android.Runtime.RuntimeNativeMethods.monodroid_TypeManager_get_java_class_name(IntPtr klass) + 0x2c
02-28 16:35:29.586 18438 18456 E NUnit : at Java.Interop.TypeManager.GetClassName(IntPtr) + 0x10
02-28 16:35:29.586 18438 18456 E NUnit : at Android.Runtime.JNIEnv.AssertCompatibleArrayTypes(IntPtr, Type) + 0x58
02-28 16:35:29.586 18438 18456 E NUnit : at Android.Runtime.JNIEnv.GetArray[T](IntPtr array_ptr) + 0x24
02-28 16:35:29.586 18438 18456 E NUnit : at Java.LangTests.ObjectArrayMarshaling.<>c__DisplayClass0_0.<CastJavaLangObjectArrayToByteArrayThrows>b__0() + 0x18
02-28 16:35:29.586 18438 18456 E NUnit : at NUnit.Framework.Assert.Throws(IResolveConstraint, TestDelegate, String, Object[]) + 0xc4
02-28 16:35:29.586 18438 18456 E NUnit : at Java.LangTests.ObjectArrayMarshaling.CastJavaLangObjectArrayToByteArrayThrows() + 0x150
02-28 16:35:29.586 18438 18456 E NUnit : at libMono.Android.NET-Tests!<BaseAddress>+0x152f704
02-28 16:35:29.586 18438 18456 E NUnit : at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x10c
I updated the remaining calls in `JNIEnv.cs` to use
`JniEnvironment.Types.GetJniTypeNameFromClass()` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono.Androidhas various test failures under NativeAOT such as:I updated the remaining calls in
JNIEnv.csto useJniEnvironment.Types.GetJniTypeNameFromClass()instead.