[nativeaot] fix missing PreserveLists\*.xml files
#9831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Context: 9bc45b5 A `dotnet new maui` project template fails to build with: obj\Release\net10.0-android\android-arm64\android\src\mono\android\runtime\InputStreamAdapter.java:4: error: InputStreamAdapter is not abstract and does not override abstract method read() in InputStream obj\Release\net10.0-android\android-arm64\android\src\mono\android\runtime\OutputStreamAdapter.java:4: error: OutputStreamAdapter is not abstract and does not override abstract method write(int) in OutputStream I found I could also reproduce this issue with the `BuildBasicApplicationAppCompat()` MSBuild test. After reviewing `.binlog` files, I found we weren't including `PreserveLists\*.xml` files *at all* in NativeAOT, as the `Condition` was false: <_PreserveLists Include="$(MSBuildThisFileDirectory)..\PreserveLists\*.xml" /> <TrimmerRootDescriptor Condition=" '@(ResolvedFileToPublish->Count())' != '0' and '%(Filename)' != '' " Include="@(_PreserveLists)" /> 9bc45b5 doesn't say why the `Condition` was added, but this was during early .NET 5 development. Some of this code may have been shared with Xamarin.Android back then. We can simply remove the `Condition` to fix this, and the MSBuild test also passes.
jonathanpeppers
force-pushed
the
dev/peppers/NativeAOTPreserve
branch
from
5d45fad to
8b95494
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
dotnet new mauiproject template fails to build with:I found I could also reproduce this issue with the
BuildBasicApplicationAppCompat()MSBuild test.After reviewing
.binlogfiles, I found we weren't includingPreserveLists\*.xmlfiles at all in NativeAOT, as theConditionwas false:9bc45b5 doesn't say why the
Conditionwas added, but this was during early .NET 5 development. Some of this code may have been shared with Xamarin.Android back then.We can simply remove the
Conditionto fix this, and the MSBuild test also passes.