[XABT] Refactor manifest merging and ACW map generation out of GenerateJavaStubs.
#9827
Conversation
|
|
||
| namespace Xamarin.Android.Tasks; | ||
|
|
||
| public class GenerateMergedAndroidManifest : AndroidTask |
There was a problem hiding this comment.
Some of this can be trimmed down since we use the android manifestmerger these days.
AndroidManifestMerger` == `legacy is what this is keyed off.
But I guess this will be a staged approach.
Maybe we can rename this task a bit? Because unless we use legacy we use another tool to generate the final manifest. Perhaps g ?
There was a problem hiding this comment.
I don't see anything that prevents this logic from running if $(AndroidManifestMerger) != 'legacy'. If that is the intention, then that is definitely something we should look into in the future.
I can rename the task GenerateLegacyMergedAndroidManifest to help make the purpose clearer?
There was a problem hiding this comment.
Well it is partially used in the new system. The main difference is the _MergedManifestDocuments ItemGroup is not populated in the new system. So that will be empty.
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm, then calling it GenerateLegacyMergedAndroidManifest is probably not a good name. Do you have a suggestion?
There was a problem hiding this comment.
maybe GenerateIntermediateAndroidManifest ?
There was a problem hiding this comment.
or GenerateMainAndroidManifest since its the "root" manifest when we finally do the merging later.
Begin breaking down the
<GenerateJavaStubs>task into smaller, more manageable pieces by moving the manifest merging and ACW map generation into separate tasks. Once this is complete, we should be able to start moving these steps that require Cecil assembly scanning into linker steps (or equivalent), eventually saving a Cecil assembly scan per build.Additionally, create a new
GetProjectBuildSpecificTaskObjectKeyto be used withGetRegisteredTaskObject. This version additional uses$(IntermediateOutpuPath)in the key to help ensure data from multi-targeted builds (net8.0-android,net9.0-android) is not overwritten.