Switch more over to System.Text.Json #9819
Draft
+125
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
force-pushed
the
dev/dellis1972/systemtextjson
branch
from
06ec5dd to
7fda7e5
Compare
src/Xamarin.Android.Build.Tasks/Tasks/JavaDependencyVerification.cs
Outdated
Show resolved
Hide resolved
dellis1972
commented
Feb 24, 2025
| @@ -60,54 +60,53 @@ public class BuildAppBundle : BundleTool | |||
| }; | |||
|
|
|||
| [Required] | |||
| public string BaseZip { get; set; } | |||
| public string BaseZip { get; set; } = ""; | |||
There was a problem hiding this comment.
Unfortunate side effect of using CoPilot. It changes other things and not just the stuff you asked it to 🤷
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dellis1972
commented
Feb 24, 2025
| public List<Package>? Packages { get; set; } | ||
| } | ||
|
|
||
| public class Package | ||
| { | ||
| [JsonProperty ("javaId")] | ||
| [JsonPropertyName ("javaId")] |
There was a problem hiding this comment.
@jonathanpeppers are these needed if we have a JsonSerializerContext? Its not clear in the docs
There was a problem hiding this comment.
I think it would put "JavaId" in the JSON without the attribute.
There might be a global setting though, for camelCase vs ProperCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.ToNode ()on the Root JsonElement to convert it to a JsonNode. (We use JsonNode to do the merging).