Move all of assembly store building code to a separate class #9382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Oct 9, 2024
This makes it possible to build assembly stores easily outside `BuildApk`
grendello
force-pushed
the
dev/grendel/assembly-store-builder
branch
from
de6a7c8 to
d4414ac
Compare
grendello
added a commit
that referenced
this pull request
Oct 14, 2024
Context: #9382 To further simplify `BuildApk`, move assembly compression code to a separate utility class. This also lets us compress assemblies from tasks other than `BuildApk`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the task of constructing assembly stores by moving all the code
which actually stashes assemblies (and their config and debug files, if found
and required) in the assembly store to a separate utility class,
AssemblyStoreBuilder.Additionally, move a portion of assembly packaging code from
BuildApkto a helper class.This makes it easier to build the stores outside of the
BuildApktask and furthersimplifies
BuildApkcode.