Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] remove Xamarin.Legacy.Sdk #9307

Merged

Conversation

jonathanpeppers
Copy link
Member

Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10234371&view=ms.vss-test-web.build-test-results-tab&runId=110872727&resultId=100056&paneView=debug

The Xamarin.Legacy.Sdk GitHub repo is archived, and no longer supported.

We still have a few tests using Xamarin.Legacy.Sdk that fail with:

error MSB4057: The target "_GetRestoreSettingsPerFramework" does not exist in the project.

It's probably related to Mono now longer installed on CI agents.

Let's remove usage of Xamarin.Legacy.Sdk from our tests.

Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10234371&view=ms.vss-test-web.build-test-results-tab&runId=110872727&resultId=100056&paneView=debug

The `Xamarin.Legacy.Sdk` GitHub repo is archived, and no longer
supported.

We still have a few tests using `Xamarin.Legacy.Sdk` that fail with:

    error MSB4057: The target "_GetRestoreSettingsPerFramework" does not exist in the project.

It's probably related to Mono now longer installed on CI agents.

Let's remove usage of `Xamarin.Legacy.Sdk` from our tests.
@jonathanpeppers
Copy link
Member Author

There are some MSBuild perf failures like Build_AndroidAsset_Change, but going to merge as these are failing on other PRs.

@jonathanpeppers jonathanpeppers merged commit 437f774 into dotnet:main Sep 17, 2024
54 of 57 checks passed
@jonathanpeppers jonathanpeppers deleted the Remove.Xamarin.Legacy.Sdk branch September 17, 2024 17:10
jonathanpeppers added a commit that referenced this pull request Sep 23, 2024
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10234371&view=ms.vss-test-web.build-test-results-tab&runId=110872727&resultId=100056&paneView=debug

The `Xamarin.Legacy.Sdk` GitHub repo is archived, and no longer
supported.

We still have a few tests using `Xamarin.Legacy.Sdk` that fail with:

    error MSB4057: The target "_GetRestoreSettingsPerFramework" does not exist in the project.

It's probably related to Mono now longer installed on CI agents.

Let's remove usage of `Xamarin.Legacy.Sdk` from our tests.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants