-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Fix the Legacy Xamarin.Android build #9255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
force-pushed
the
dev/jonp/jonp-fix-d17.5-build
branch
from
August 28, 2024 14:39
005ce52
to
cb755bb
Compare
Fixes: #9253 Fixes: #9048 Multiple reports that `make prepare` now errors out: % make prepare … =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Downloading Mono archive =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Checking if all runtime files are present • some files are missing, download and extraction required Downloading Mono archive from https://xamjenkinsartifact.azureedge.net/mono-sdks/android-debug-Darwin-d9a6e8710b37cd7f16cf52eff4f772556e57cc41.7z Failed to obtain Mono archive size. HTTP status code: BadRequest (400). Mono runtimes will be rebuilt Downloading Mono archive from https://xamjenkinsartifact.azureedge.net/mono-sdks/android-debug-Darwin-d9a6e8710b37cd7f16cf52eff4f772556e57cc41.7z Failed to obtain Mono archive size. HTTP status code: BadRequest (400). Mono runtimes will be rebuilt Downloading Mono archive from https://xamjenkinsartifact.azureedge.net/mono-sdks/android-debug-Darwin-d9a6e8710b37cd7f16cf52eff4f772556e57cc41.7z Failed to obtain Mono archive size. HTTP status code: BadRequest (400). Mono runtimes will be rebuilt Mono archive not present =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Installing Mono runtimes =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Step Xamarin.Android.Prepare.Step_InstallMonoRuntimes failed: Unable to build mono runtimes from sources. System.InvalidOperationException: Step Xamarin.Android.Prepare.Step_InstallMonoRuntimes failed: Unable to build mono runtimes from sources. ---> System.NotImplementedException: Unable to build mono runtimes from sources. at Xamarin.Android.Prepare.Step_InstallMonoRuntimes.Execute(Context context) in /Users/wangyk/Projects/Practice/xamarin-android/build-tools/xaprepare/xaprepare/Steps/Step_InstallMonoRuntimes.cs:line 34 at Xamarin.Android.Prepare.Step.Run(Context context) in /Users/wangyk/Projects/Practice/xamarin-android/build-tools/xaprepare/xaprepare/Application/Step.cs:line 42 at Xamarin.Android.Prepare.Scenario.Run(Context context, Log log) in /Users/wangyk/Projects/Practice/xamarin-android/build-tools/xaprepare/xaprepare/Application/Scenario.cs:line 37 --- End of inner exception stack trace --- at Xamarin.Android.Prepare.Scenario.Run(Context context, Log log) in /Users/wangyk/Projects/Practice/xamarin-android/build-tools/xaprepare/xaprepare/Application/Scenario.cs:line 48 at Xamarin.Android.Prepare.Context.Execute() in /Users/wangyk/Projects/Practice/xamarin-android/build-tools/xaprepare/xaprepare/Application/Context.cs:line 845 at Xamarin.Android.Prepare.App.Run(String[] args) in /Users/wangyk/Projects/Practice/xamarin-android/build-tools/xaprepare/xaprepare/Main.cs:line 174 This happens because the URL <https://xamjenkinsartifact.azureedge.net> no longer exists (for various sundry internal reasons), and was replaced by <https://download.mono-project.com>. Update `$(MonoDarwinPackageUrl)` to use the new URL. Update `Configurables.Urls.MonoArchive_BaseUri` to use the new URL. Additionally, the new URL only contains *release* artifacts. Update `Configurables.Defaults.MonoSdksConfiguration` to always be `release` so that the appropriate archive and extracted directories are used.
jonpryor
force-pushed
the
dev/jonp/jonp-fix-d17.5-build
branch
from
August 28, 2024 14:50
cb755bb
to
265be09
Compare
grendello
approved these changes
Aug 28, 2024
GitHub redirects xamarin/xamarin-android to dotnet/android, causing e.g. `AndroidHandlerTestBase.Redirect_Without_Protocol_Works()` to fail. Update the expected URLs so they pass as expected.
@jonpryor |
This was referenced Aug 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9253
Fixes: #9048
Multiple reports that
make prepare
now errors out:This happens because the URL
https://xamjenkinsartifact.azureedge.net/mono-sdks no longer exists (for various sundry internal reasons), and was replaced by https://download.mono-project.com/mono-sdks.
Update
Configurables.Urls.MonoArchive_BaseUri
to use the new URL.Additionally, the new URL only contains release artifacts. Update
Configurables.Defaults.MonoSdksConfiguration
to always berelease
so that the appropriate archive and extracted directories are used.