[tests] update MSBuild performance tests #9231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been a while, since I went through and refactored these tests. After seeing a couple build-time regressions in .NET 9, I think it's overdue. Removing test cases that likely won't catch an issue: * `Build_Designer_Change` (less concerned about designer now) * `Build_CSProj_Change` `Build_From_Clean_DontIncludeRestore` would likely catch similar issues as these two, anyway. `Build_XAML_Change_RefAssembly` now uses a `net8.0` class library where `$(ProduceReferenceAssembly)` defaults to `true`. Removed a 500ms addition, that only made sense when we supported both "classic" Xamarin.Android and .NET 6+ projects. Update the time thresholds to be a bit shorter, in general.
jonathanpeppers
force-pushed
the
MSBuildPerf
branch
from
3ca20a1 to
df34e11
Compare
dellis1972
reviewed
Aug 21, 2024
dellis1972
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while, since I went through and refactored these tests. After seeing a couple build-time regressions in .NET 9, I think it's overdue.
Removing test cases that likely won't catch an issue:
Build_Designer_Change(less concerned about designer now)Build_CSProj_ChangeBuild_From_Clean_DontIncludeRestorewould likely catch similar issues as these two, anyway.Build_XAML_Change_RefAssemblynow uses anet8.0class library where$(ProduceReferenceAssembly)defaults totrue.Removed a 500ms addition, that only made sense when we supported both "classic" Xamarin.Android and .NET 6+ projects.
Update the time thresholds to be a bit shorter, in general.