Remove Enhanced Fast Deployment #8959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will close #2730. |
|
We need this one https://github.com/xamarin/monodroid/pull/1485. |
pjcollins
approved these changes
May 28, 2024
grendello
added a commit
that referenced
this pull request
Jun 3, 2024
* main: [ci] Update .NET version installed for MAUI tests (#8995) [ci] Run "Push Internal" job on AzurePipelines-EO pool (#8991) [Xamarin.Android.Build.Tasks] LLVM Marshal Methods by Default, Take 2 (#8925) $(AndroidPackVersionSuffix)=preview.6; net9 is 34.99.0.preview.6 (#8989) [ci] Update path for generated `*.include.*` files (#8980) Bump to xamarin/xamarin-android-tools/main@da2c33e (#8984) Bump to xamarin/Java.Interop/main@f935001 (#8985) Bump to xamarin/monodroid@93ab95e18 (#8959) Force loc task pool image to windows (#8983) [git] Re-format `.gitmodules` (#8978)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://github.com/xamarin/monodroid/pull/1481
Context #2730
Bump monodroid to bring in the following changes.
Changes https://github.com/xamarin/monodroid/compare/9ca6d9f64fce11f04d668ece50ada36de1d7efce...93ab95e18077d56d9d55ce7b4069a534e2dea35e.
The biggest of these changes is the removal of Enhanced Fast Deplyment. This change removes the ability to side load
.dex,.soand resources in the same directory as we sideload assemblies. This feature was always hard to maintain as it used a bunch of android API's which are deprecated or have very little documentation. It also did not work forApplicationsubcalsses. This restriction alone makes it impossible to use this feature with Maui.Given its maintainance issues and the lack of use among our customer base it is best is we remove this feature.
The default Fast Deployment of assemblies will still function as it currently does now. Only the side loading of
.dex,.soand resources is being removed.Add a
XA1037warning to tell users that theAndroidFastDeploymentTypeis no longer supported.Add a new test
XA1037PropertyDeprecatedWarningwhich makes sure that the areas using the genericXA1037warning are producing a correct message.